Conversation
* 3.7 compat * black linting * typo
New build-arg is required.
* Add Pre-commit to project To run: - pip install -r nativerl/python/requirements-dev.txt - pre-commit install When you create a commit it will automatically lint and format your code. Don't autoflake __init__.py files * Add github workflow to check python code in PR Adapt github flow for nativerl Add pytest to dev requirements Enable pytests on git commits * Ignore venv folder * Apply pre-commit recommendations - Sort imports in python files - check for newline at end of file - Format markdown - Apply Black formatting for Python * Update tests for `get_callbacks()` * Update tests for `get_scheduler()` * Add `getRewardTerms()` to cartpole example This was the minimum to get it to pass tests. I don't know if it will train. * Update test for stopper * Lock aioredis version to compatible version * Create different folders for the training auto tests Otherwise they fail the second time you run them * Set up github check to fail fast - pre-commit before dependencies - unit tests before integration tests * Skip flake for now for known issues I filed two github issues to follow-up on. * Get test_policy_serving to pass Queries a policy server hosted by the webapp that was trained on the AnyLogic model. - Adapt mouse_and_cheese to match anylogic observations This will let us use the current policy server. - Move policy serving to integration tests * WIP - get test training to pass for Pathmind Simulations * WIP - xfail tests for policy serving and training - Policy serving tests depend on an update in pathmind-api Switch to the right dir to run pytests fixup - change to right directory for training tests fixup - more tests expected to pass now * Add basic instructions to README * Update README.md for specific rllib version
Also enables the test again. Fixes #444
* Remove noqa in offending file * Replace `is` with `==`
content by @brettskymind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.