Stripe checkout onboarding service - #2991
Conversation
|
looking good so far . Check it out @ejunprung |
|
That's perfect. When someone pays, where will the notifications go? Just need a way to check if someone had paid or not. I can log into Stripe and stuff as well, whichever is less work. |
|
We should hook it up from our serverside to segment. That will notify intercom |
|
Can someone please add me to the Stripe team as a "developer"? |
…com:SkymindIO/pathmind-webapp into dev-2990-stripe-checkout-onboarding-service
|
run tests |
|
@fionnachan There is an error in Jenkins https://jenkins.dev.devpathmind.com/job/Test_PRs/4531/execution/node/47/log/ [�[1;34mINFO�[m] Pathmind Punctuator ................................ �[1;32mSUCCESS�[m [ 0.449 s] |
|
@slinlee do we need to include tax for this payment? |
@ejunprung do we need to? |
|
I added a segment event on successful payment |
| pathmind.email.from.name=Pathmind | ||
| pathmind.application.url=${APPLICATION_URL:http://localhost:8080} | ||
| pathmind.application.environment=${ENVIRONMENT} | ||
| pathmind.pathmind-api.url=${PATHMIND_API_URL:http://localhost:8081} |
|
Thanks, @fionnachan. I have added it to Jenkins; please let me know if you need anything else. |
alethander
left a comment
There was a problem hiding this comment.
there are few changes needed to replace System.out and e.printStackTrace with log.
is there documentation on integration with Stripe?
We need the URL to be pathmind-api's URL at different environment.... can we set the env value for |
|
@alexamakarov yes here are the docs: |
2f2f67b to
cc01901
Compare
|
Sorry, forgot to update the status after talking to Alex. @alexamakarov would like to take over the PR to do some cleanups on the On another note, the only blocker for merging this PR here is that the PR tests cannot trigger the I'll message @xneyder about configuring the webhook signing secret for different environments. |
|
@EvgeniyEA yes it's the same issue mentioned above because of the stripe webhook secret and its endpoint.... I'm not sure if there's a way to get around this without deploying the site since our Worst case is we might need to disable the e2e tests that involves the "Stripe page" step before merging this PR. |
|
@EvgeniyEA Now that I think about it, the standard way to test this would be to mock Stripe API calls instead of actually calling the Stripe service. Would you know if that is possible? |
|
@fionnachan we can try with https://github.com/stripe/stripe-mock |
slinlee
left a comment
There was a problem hiding this comment.
Thanks.
@alexamakarov - what types of changes did you have in mind for the API?
Stripe checkout onboarding service (#2991)

Changes
PR Screenshots
Site header



Checkout page hosted on Stripe
Success Page
Closes #2990