Auth: fix verify page stuck on spinner under StrictMode#50
Open
RandyJDean wants to merge 1 commit into
Conversation
The verify POST fired from a mount effect via useMutation, and StrictMode's simulated remount detaches the mutation observer from its in-flight request — the component never saw success (no navigation, spinner forever) even though the backend signed the user in. Model the token exchange as a query keyed by the token instead: the StrictMode double-mount dedupes to a single POST and the remounted observer re-attaches to the cached entry. The page now derives navigation from query state, dropping the effect + ref guard entirely. Wrap the test renderer in StrictMode to mirror main.tsx so this class of bug fails in vitest instead of only in the browser. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
|
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/10/26)2 reviewers were added to this PR based on Henry Chen's automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verify POST fired from a mount effect via useMutation, and
StrictMode's simulated remount detaches the mutation observer from its
in-flight request — the component never saw success (no navigation,
spinner forever) even though the backend signed the user in.
Model the token exchange as a query keyed by the token instead: the
StrictMode double-mount dedupes to a single POST and the remounted
observer re-attaches to the cached entry. The page now derives
navigation from query state, dropping the effect + ref guard entirely.
Wrap the test renderer in StrictMode to mirror main.tsx so this class
of bug fails in vitest instead of only in the browser.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com