Skip to content

test: keep scoped memory fixtures fresh#126

Merged
PatrickSys merged 2 commits into
masterfrom
agent/fix-scoped-memory-fixtures
Jul 25, 2026
Merged

test: keep scoped memory fixtures fresh#126
PatrickSys merged 2 commits into
masterfrom
agent/fix-scoped-memory-fixtures

Conversation

@PatrickSys

Copy link
Copy Markdown
Owner

Summary

Keep the scoped-memory test fixtures fresh so confidence decay does not filter the expected scoped memory before the ranking assertion runs.

Root cause

The fixtures used a fixed April 2026 timestamp. As time passed, decay dropped the scoped memory below the compact-mode confidence threshold, causing two unrelated ranking tests to fail.

Verification

  • pnpm run build
  • pnpm test -- tests/search-health-scope.test.ts tests/search-scoped-memory.test.ts
  • pnpm test — 612 passed

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@PatrickSys
PatrickSys marked this pull request as ready for review July 25, 2026 18:13
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@greptile-apps

greptile-apps Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Keeps scoped-memory test fixtures above the confidence-decay threshold by assigning both scoped and global memories the test setup’s current timestamp.

  • Updates health-and-scope search fixtures to use a fresh timestamp.
  • Updates scoped-memory ranking fixtures to use the same fresh-timestamp approach.

Confidence Score: 5/5

The PR appears safe to merge, with both test-only changes directly addressing time-dependent fixture decay.

The changed timestamps preserve the tests’ intended scoped-memory eligibility while leaving production behavior and asserted ranking semantics unchanged.

Important Files Changed

Filename Overview
tests/search-health-scope.test.ts Replaces aging fixed memory dates with a shared setup-time timestamp, preventing unrelated confidence filtering from destabilizing health and scope assertions.
tests/search-scoped-memory.test.ts Keeps scoped-memory fixtures fresh so the test continues exercising scope-based ranking rather than fixture-age decay.

Reviews (1): Last reviewed commit: "test: keep scoped memory fixtures fresh" | Re-trigger Greptile

@PatrickSys
PatrickSys merged commit d009d8e into master Jul 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant