fix: apply 193 confirmed findings from full-codebase review#127
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Rebuilds the full-codebase-review changes on top of current main. Brings the genuine fixes while preserving everything that landed on main after the review branch was cut: completion-aware call(wait=True)/CallResult, built-in transfer_call/end_call injection in pipeline mode, Plivo carrier, and the modern is_ws_alive websocket-liveness check. Closes the one-sided Python<->TS parity gaps the review left open and corrects defects it introduced. The default Agent.model is aligned across both SDKs to gpt-realtime-mini (matching the TypeScript adapter default and the Python agent() helper); both names are aliases for the same model family and share the same pricing. The realtime-pricing calibration warning now treats both as default-calibrated. Internal review artifacts (docs/reviews/*, docs/DEVLOG.md) were intentionally not carried over. See CHANGELOG.md (## Unreleased) for the user-visible list.
055ad02 to
3be6430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainso it ships only the genuine fixes from the full-codebase review, with zero regressions of features that landed onmainafter the original branch was cut.Implementation
origin/main; ported the review's real fixes (the 92 files only this PR touched applied cleanly; the 20 filesmainalso changed were manually merged withmainas the base), then rebased onto the latestmain.main(a naïve merge would have silently deleted these):call(wait=True)/CallResult(feat: completion-aware outbound calls — call(wait=True) → CallResult + guaranteed teardown #120), built-intransfer_call/end_callinjection in pipeline mode (fix(pipeline): inject built-in transfer_call / end_call tools into LLMLoop #115/fix(typescript): pipeline built-in tools + docs events parity for #114/#115 + CHANGELOG backfill #118), Plivo carrier (feat(plivo): add Plivo as a third carrier with full Twilio/Telnyx parity #121/chore(plivo): close remaining gaps — dashboard UI, lib READMEs, packaging keywords #123),is_ws_alivewebsocket-liveness (fix(websockets): use is_ws_alive across modern websockets>=12 API #113), the pipeline metrics re-arm (fix(metrics): re-arm turn guard in anchorUserSpeechStart — pipeline turns emit no metrics/transcript #125), and the security scrub (chore(security): scrub production Call SID and competitor lineage from public files #129).FallbackLLMProvider.cancel_event(Py), Telnyx STT cost (TS),PatterConfigError(TS), Azure cached-token savings (TS), Anthropic cache-token billing (TS).done_callbackcancelled-guards,DTMF_EVENTSordering, OpenAI TTS default restored, EOU emit guard aligned, orphaned conversation-history turn, Telnyx STT logger namespace.Agent.modelaligned across SDKs togpt-realtime-mini(matches the TS adapter default; same model family / pricing).docs/reviews/*,docs/DEVLOG.md) and the original unauthorized model-default change are not included.Breaking change?
No runtime breaking change. Two notes for callers:
list/array must compare against a tuple/readonly array.Agent.modeldefault string changedgpt-4o-mini-realtime-preview→gpt-realtime-mini(aliases for the same model, identical pricing).Test plan
pytest tests/— 1940 passednpm test(1555 passed) +npm run lint(clean) +npm run build(success)tsc --noEmitcleanDocs updates
CHANGELOG.md## Unreleasedupdated; nodocs/**.mdxpages touched.