Skip to content

fix: apply 193 confirmed findings from full-codebase review#127

Merged
nicolotognoni merged 1 commit into
mainfrom
fix/full-codebase-review-2026-05-29
May 31, 2026
Merged

fix: apply 193 confirmed findings from full-codebase review#127
nicolotognoni merged 1 commit into
mainfrom
fix/full-codebase-review-2026-05-29

Conversation

@FrancescoRosciano
Copy link
Copy Markdown
Collaborator

@FrancescoRosciano FrancescoRosciano commented May 30, 2026

Summary

  • Rebuilds this PR on top of current main so it ships only the genuine fixes from the full-codebase review, with zero regressions of features that landed on main after the original branch was cut.
  • Closes the one-sided Python↔TypeScript parity gaps the review left open and corrects the defects it introduced.
  • Drops the internal review artifacts and the unauthorized model-default change that were in the original branch.

Implementation

Breaking change?

No runtime breaking change. Two notes for callers:

  • Public config collections are now immutable (frozen tuples / readonly arrays) — code comparing them against a plain list/array must compare against a tuple/readonly array.
  • Agent.model default string changed gpt-4o-mini-realtime-previewgpt-realtime-mini (aliases for the same model, identical pricing).

Test plan

Docs updates

  • N/A — CHANGELOG.md ## Unreleased updated; no docs/**.mdx pages touched.

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 30, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
patter-06b046ce 🟢 Ready View Preview May 30, 2026, 4:22 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Rebuilds the full-codebase-review changes on top of current main. Brings the
genuine fixes while preserving everything that landed on main after the review
branch was cut: completion-aware call(wait=True)/CallResult, built-in
transfer_call/end_call injection in pipeline mode, Plivo carrier, and the
modern is_ws_alive websocket-liveness check. Closes the one-sided Python<->TS
parity gaps the review left open and corrects defects it introduced.

The default Agent.model is aligned across both SDKs to gpt-realtime-mini
(matching the TypeScript adapter default and the Python agent() helper); both
names are aliases for the same model family and share the same pricing. The
realtime-pricing calibration warning now treats both as default-calibrated.
Internal review artifacts (docs/reviews/*, docs/DEVLOG.md) were intentionally
not carried over.

See CHANGELOG.md (## Unreleased) for the user-visible list.
@nicolotognoni nicolotognoni force-pushed the fix/full-codebase-review-2026-05-29 branch from 055ad02 to 3be6430 Compare May 31, 2026 01:45
@nicolotognoni nicolotognoni merged commit 950b8d6 into main May 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants