chore(security): scrub production Call SID and competitor lineage from public files#129
Merged
Merged
Conversation
…m public files - CHANGELOG.md: remove a live Twilio Call SID and two private acceptance-repo path crumbs from the 0.6.1 release notes. A Call SID is production-call PII that security.md forbids in the public repo. - stream-handler.ts: rewrite a pacing comment to drop a competitor lineage reference (TwilioFrameSerializer / call-gpt sample) and two non-English user-complaint quotes, restating the rationale in neutral English. Comment-only; no behaviour change. The Python stream_handler twin was already clean. These strings remain in git history (working-tree scrub only) — the Call SID is an opaque, non-credential resource ID, accepted as low-risk per maintainer review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two public-repo policy violations found during a full-tree audit, scrubbed from the working tree:
CHANGELOG.md(0.6.1 release notes) —security.mdforbids real call SIDs in the repo. Also removed two private acceptance-repo path crumbs (releases/0.6.0/.../outbound-cartesia-cerebras-elevenlabs.ts) from the same two entries.stream-handler.tspacing comment — referenced a competitor's frame serializer and a Twilio sample, and quoted a user complaint in Italian. Rewritten to neutral English, same technical content. Comment-only, no behaviour change. The Python twin was already clean.Breaking change?
No — comment + release-notes text only.
Note on git history
Per maintainer decision, this is a working-tree scrub only; the strings remain reachable in git history. The Call SID is an opaque, non-credential resource ID (querying it requires the account auth token), accepted as low-risk — no history rewrite.
Test plan