use round instead of intval to convert amount to kobo#14
Merged
whales-paystack merged 1 commit intomasterfrom Aug 26, 2021
Merged
use round instead of intval to convert amount to kobo#14whales-paystack merged 1 commit intomasterfrom
whales-paystack merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this change made?
A bug was reported where the Paystack checkout was loading a different amount than what was set in WHMCS, we traced this to an error in the line
$amountinkobo = intval(floatval($params['amount']) * 100); //where $params['amount'] is 19.74, the checkout loaded 19.73 instead.
It's unclear why this is happening, but using round() in place of intval() appears to resolve the issue.
Ref #? (Enter an issue this references.)
https://paystack.zendesk.com/agent/tickets/944623
----- READ, then delete below this line -----
IMPORTANT!
Please be sure to send a coherent commit history - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting. Here's an article we'd like you to read > http://chris.beams.io/posts/git-commit/