Add woodCreation as output - #161
Conversation
|
@cami-webb Thanks for your contribution. This seems like a useful addition and we'd like to merge it. Let us know when it is ready. But to clarify: was woodCreation previously written out? Although woodCreation appears in the PEcAn code (model2netcdf.SIPNET.R#L179), @Alomir and I have been unable to find it being written to sipnet.out in previous versions of the SIPNET code. So it seems likely that it was written out at some point, but do you know where in the code this was, or do you have a version of the SIPNET binary that does write it out? This is primarily in the interest of tracking down a potential bug. Thanks! Finally, your description says WIP - please update when this is ready to merge. |
It should be ready now. I am not exactly sure when/where it was written out, as my work with GWBI used PEcAn code and worked fine, then I switched to Dongchen Zhang's version of PEcAn from his most recent PR and woodCreation was no longer outputted. I don't have my old version of PEcAn that I was using previously unfortunately. |
Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>
|
FYI, I added some tweaks to |
Alomir
left a comment
There was a problem hiding this comment.
Looks good, thanks for putting together the PR!
Added woodCreation back as an output of sub.sipnet.output
@dlebauer edit:
PR motivation (from separate Slack thread): the intent of writing woodCreation to sipnet.out is to use it as an estimate of Gross Woody Biomass Increment (GWBI), which will be used for assimilation of tree ring and forest inventory data.