Skip to content

Add woodCreation as output - #161

Merged
Alomir merged 6 commits into
PecanProject:masterfrom
cami-webb:woodCreation
Oct 16, 2025
Merged

Add woodCreation as output#161
Alomir merged 6 commits into
PecanProject:masterfrom
cami-webb:woodCreation

Conversation

@cami-webb

@cami-webb cami-webb commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Added woodCreation back as an output of sub.sipnet.output


@dlebauer edit:

PR motivation (from separate Slack thread): the intent of writing woodCreation to sipnet.out is to use it as an estimate of Gross Woody Biomass Increment (GWBI), which will be used for assimilation of tree ring and forest inventory data.

@dlebauer

Copy link
Copy Markdown
Member

@cami-webb Thanks for your contribution. This seems like a useful addition and we'd like to merge it. Let us know when it is ready.

But to clarify: was woodCreation previously written out? Although woodCreation appears in the PEcAn code (model2netcdf.SIPNET.R#L179), @Alomir and I have been unable to find it being written to sipnet.out in previous versions of the SIPNET code. So it seems likely that it was written out at some point, but do you know where in the code this was, or do you have a version of the SIPNET binary that does write it out? This is primarily in the interest of tracking down a potential bug. Thanks!

Finally, your description says WIP - please update when this is ready to merge.

@cami-webb cami-webb closed this Oct 14, 2025
@cami-webb cami-webb reopened this Oct 14, 2025
@cami-webb

Copy link
Copy Markdown
Contributor Author

@cami-webb Thanks for your contribution. This seems like a useful addition and we'd like to merge it. Let us know when it is ready.

But to clarify: was woodCreation previously written out? Although woodCreation appears in the PEcAn code (model2netcdf.SIPNET.R#L179), @Alomir and I have been unable to find it being written to sipnet.out in previous versions of the SIPNET code. So it seems likely that it was written out at some point, but do you know where in the code this was, or do you have a version of the SIPNET binary that does write it out? This is primarily in the interest of tracking down a potential bug. Thanks!

Finally, your description says WIP - please update when this is ready to merge.

It should be ready now. I am not exactly sure when/where it was written out, as my work with GWBI used PEcAn code and worked fine, then I switched to Dongchen Zhang's version of PEcAn from his most recent PR and woodCreation was no longer outputted. I don't have my old version of PEcAn that I was using previously unfortunately.

@dlebauer
dlebauer requested a review from Alomir October 14, 2025 20:05
Comment thread src/sipnet/sipnet.c Outdated
cami-webb and others added 2 commits October 14, 2025 17:40
Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>
@Alomir

Alomir commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

FYI, I added some tweaks to tools/smoke_check.py to print more info when output columns have changed - this seemed like the correct place to do that.

@Alomir Alomir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for putting together the PR!

@Alomir
Alomir merged commit 85a136b into PecanProject:master Oct 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants