Reformulation of nitrogen fixation: dependent on plant N uptake and availability of Nmin #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove t dependence of N fixation. N fixation is proportional to NPP, which itself is proportional to temperature. I did not find evidence for other models using T dependence.
dlebauer
commented
Nov 19, 2025
dlebauer
commented
Nov 19, 2025
Alomir
reviewed
Nov 19, 2025
docs/model-structure.md
Outdated
| $$ | ||
|
|
||
| Nitrogen fixation is represented by adding fixed nitrogen directly to the soil mineral nitrogen pool. This is a reasonable first approximation, consistent with the simplicity of the nitrogen limitation model where limitation only occurs when nitrogen demand exceeds supply. | ||
| <!-- do parameter estimates / ranges go in this doc? in the params doc? |
Collaborator
There was a problem hiding this comment.
Seems like this would be great in the params doc
Alomir
approved these changes
Nov 19, 2025
Collaborator
Alomir
left a comment
Alomir
left a comment
There was a problem hiding this comment.
Looks good! Might want to put the parameter estimate into the params doc, but that can be here in this PR or elsewhere
…N demand modified by Nmin availability
dlebauer
changed the title
dlebauer
commented
Nov 20, 2025
dlebauer
commented
Nov 20, 2025
…dit N fixation / N demand description
…I changed some \eqref to \ref
Member
Author
|
@Alomir RE:
I changed the formulation since that note, so didn't carry over this particular value, but drafted a document for priors and default values in #194 so that next time there would be a place to take notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace N fixation as f(NPP) with N fixation = f(N demand, N availability).
Any further modifications, other than reversion to N_fix = a * NPP, should be proposed as a separate pull request.
Highlights (from rendered model-structure.md):