Split root-count tactic into theorem and frontend layers - #515
Merged
Conversation
PerAlexandersson
deleted the
refactor/root-count-tactic-layers-20260904
branch
September 4, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tactic.RootCountmixed module with a compatibilityfacade over six theorem, syntax, and macro-rule layers
SequenceCoreandLowDegreetheorem APIs whilepreserving all 191 established theorem/syntax declarations and all 124
tactic spellings
Nat.le_or_eq_of_le_succ, removing the negated case split andliaDependency effect
SequenceCore: 83 modules / 30,789 local linesLowDegree: 136 modules / 59,977 local linesVerification
Tactic,Tactic.OEIS, andTactic.Examples.RootCountlake-workspace build RealRooted: 9,401 jobs passedpropext,Classical.choice, andQuot.soundgit diff --checkAristotle
Owner-labeled advisory project
a081360c-f706-4531-b949-b6b47fb79f66, task84b3da16-38b1-4220-b56c-3b897e957855, is independently proof-golfing thelow-degree endpoint against public merge
5d2ad085. It is intentionally not amerge gate; any worthwhile result will require a separate local replay and
follow-up checkpoint.