fix: correctly decode and validate basic auth for metrics (#151)

[SinghAman21]

Changes

Write here about the changes you've made

Why

Write here why you think this should be merged

Critical auth bug, read issue #151

Checkmarks

• The modified endpoints have been tested.
• Used the same indentation as the rest of the project.
• Still compatible with LavaLink clients.

Additional information

If you have any additional information, write it here

Basic YWRtaW46eW91c2hhbGxub3RwYXNz" === "Basic admin:youshallnotpass -> FALSE || 401
new code does is decoding the base64 and breaks after : and checks the password

[1Lucas1apk]

It was tested, and from what I've tested it's fixed, but wouldn't it be interesting to add the option to enter a username for authentication with BASIC?

[SinghAman21]

oh got it, it will be a simple one. just have to handle new parameter username.
will first check with config.ts then make changes in the default.config.ts

[SinghAman21]

It was tested, and from what I've tested it's fixed, but wouldn't it be interesting to add the option to enter a username for authentication with BASIC?

oh got it, it will be a simple one. just have to handle new parameter username. will first check with config.ts then make changes in the default.config.ts

echo -n "admin:youshallnotpass" | base64  -> YWRtaW46eW91c2hhbGxub3RwYXNz

curl -v -H "Authorization: Bearer YWRtaW46eW91c2hhbGxub3RwYXNz" http://localhost:3000/v4/metrics

[1Lucas1apk]

It was tested and confirmed, thank you very much for reporting the bug and fixing it.

[SinghAman21]

btw @1Lucas1apk wanted to know your expectations from the Winter of code proposal, if you may.

[1Lucas1apk]

As a mentor, I hope Winter of Code, together with LeetCode, becomes a shared learning experience. Sometimes we overlook very small details, and other people can spot them more easily, or have more experience in certain areas, which helps keep the project consistent and well maintained, just like what you have been doing.

I also hope contributors who are being mentored through the projects can learn even more by contributing for real, getting feedback in code reviews, improving step by step, and building the confidence to keep contributing after the event. Overall, that is my view: collaboration, continuous improvement, and real open source learning :)