fix: bump minimum Perl to 5.008, remove IO::String fallback#362
Draft
toddr-bot wants to merge 2 commits into
Draft
fix: bump minimum Perl to 5.008, remove IO::String fallback#362toddr-bot wants to merge 2 commits into
toddr-bot wants to merge 2 commits into
Conversation
Remove Token/Data.pm exclusion from xt/author/pmv.t so it gets checked by Test::MinimumVersion. Add a TODO test verifying IO::String is not loaded when running on 5.008+. These tests expose the issue: Token/Data.pm uses scalar-ref open (a 5.008 feature) but the declared minimum version is 5.006. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PPI::Token::Data uses three-arg open with a scalar ref (in-memory filehandle), which requires Perl 5.008. The declared minimum was 5.006 with an IO::String fallback for older perls and a pmv.t exclusion to suppress the Test::MinimumVersion failure. Since Perl 5.6 reached end of life in 2003, bump the minimum to 5.008 and remove all the compatibility scaffolding: - use 5.008 in PPI.pm and PPI::XSAccessor.pm - Remove IO::String conditional loading from Token/Data.pm - Remove IO::String dynamic prereq from dist.ini - Remove Token/Data.pm exclusion from xt/author/pmv.t - Remove IO::String special case from t/19_selftesting.t - Simplify t/13_data.t handle type check Fixes #268 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the declared minimum Perl version from 5.006 to 5.008 and removes the IO::String compatibility code from PPI::Token::Data. The module uses three-arg
openwith a scalar ref (in-memory filehandle), which is a 5.008 feature. Previously this was worked around with an IO::String fallback and a Test::MinimumVersion exclusion.Fixes #268
Changes
use 5.008in PPI.pm and PPI::XSAccessor.pm (wasuse 5.006)IO::Stringdynamic prereq from dist.iniTest plan
t/13_data.tnow unconditionally asserts handle is a GLOBxt/author/pmv.tno longer excludes Token/Data.pm from minimum version checksGenerated by Kōan /fix
Quality Report
Changes: 7 files changed, 9 insertions(+), 26 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline