fix: add regression tests for issue #133 (wordlike operator after method call)#398
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: add regression tests for issue #133 (wordlike operator after method call)#398toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
…(GH #133) The underlying bug (wordlike operators like x and cmp being parsed as Word instead of Operator after method calls without parens) was already fixed. Add explicit regression tests for the specific examples from the issue report to prevent future regressions: - $a->dat x 2 (method call on variable without parens) - $a->dat() x 2 (method call with parens, for contrast) - map { LD_H x 3 } @list (bareword x inside map block) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug reported in #133 (wordlike operators like
xandcmpbeing parsed asWordinstead ofOperatorafter method calls without parentheses) was already fixed in the codebase. This PR adds explicit regression tests for the specific examples from the issue report to prevent future regressions and formally close the issue.Fixes #133
Changes
$a->dat x 2;— method call on variable without parens,xcorrectly parsed as Operator$a->dat() x 2;— method call with parens (contrast case)map { LD_H x 3 } @list— bareword followed byxinside map blockTest plan
t/ppi_token_operator.tpassGenerated by Kōan /fix
Quality Report
Changes: 1 file changed, 54 insertions(+), 1 deletion(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline