Set builtin:: globs to readonly so that attempted replacements of them do not break optimisations
#22657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m do not break optimisations
leonerd
force-pushed
the
builtin-functions-readonly
branch
from
706e8be to
8ccf441
Compare
Contributor
Author
|
Abandoning this one now as instead we just documented "don't do this". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible thought, based on discussions on p5p@ about optimisations around builtin functions.
Currently just emits the default "Modification of read-only value" message. I did attempt to have it say something special in this situation but that involves editing
Perll_sv_setsv_flags()in sv.c, one of the hottest paths in the entire interpreter. I didn't think that was especially worth it just for this very rare case.This is an alternative to #22668