Revert recent intuit_more() changes

[khwilliamson]

It's too late in the development cycle to be risking these kinds of changes.
This action was requested in #24340 (comment)

• This set of changes does not require a perldelta entry.

[jkeenan]

Today I built a threaded, debugging perl from the branch in pull request GH #24367, "Revert recent intuit_more() changes."

$ gitcurr
gh-24367-khwilliamson-backout_intuit_more-20260413
$ cc --version | head -n1
cc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0
$ extract-sha
573e905359
$ ./bin/perl -Ilib -V:config_args
config_args='-des -Dusedevel -Duseithreads -DDEBUGGING ...'

I then tried to install the CPAN modules mentioned in this and other reverted tickets.

I successfully used cpan to install App::CPAN::Mini::Visit (GH #24340) against it.

$ export MOD='App::CPAN::Mini::Visit'
$ ./bin/perl -Ilib -M$MOD -E 'my $v = "$ENV{MOD}::VERSION"; say join q{|} => $ENV{MOD}, ${$v};'
App::CPAN::Mini::Visit|0.008

I successfully used cpan to install Proc::Async (GH #24336) against it.

$ export MOD='Proc::Async'
$ ./bin/perl -Ilib -M$MOD -E 'my $v = "$ENV{MOD}::VERSION"; say join q{|} => $ENV{MOD}, ${$v};'
Proc::Async|0.2.0

However, I was unable to install Biblio::SICI (GH #24339).

 $THISPROVE -vb t/003_parse.t t/004_assemble_basic.t 
t/003_parse.t ........... 
ok 1 - 'object instantiated' isa 'Biblio::SICI'
perl: pp_hot.c:2311: Perl_pp_padav: Assertion `SvTYPE(TARG) == SVt_PVAV' failed.
All 1 subtests passed 
t/004_assemble_basic.t .. 
ok 1 - 'object instantiated' isa 'Biblio::SICI'
perl: pp_hot.c:2311: Perl_pp_padav: Assertion `SvTYPE(TARG) == SVt_PVAV' failed.
All 1 subtests passed 

Test Summary Report
-------------------
t/003_parse.t         (Wstat: 134 (Signal: ABRT, dumped core) Tests: 1 Failed: 0)
  Non-zero wait status: 134
  Parse errors: No plan found in TAP output
t/004_assemble_basic.t (Wstat: 134 (Signal: ABRT, dumped core) Tests: 1 Failed: 0)
  Non-zero wait status: 134
  Parse errors: No plan found in TAP output
Files=2, Tests=2,  2 wallclock secs ( 0.01 usr  0.01 sys +  0.09 cusr  0.00 csys =  0.11 CPU)
Result: FAIL

I was also unable to install String-Equivalence-Amharic (GH #24229).

$ ./Build test
t/01downgrade.t .. perl: utf8.c:72: Perl_force_out_malformed_utf8_message_: Assertion `p < e' failed.
t/01downgrade.t .. No subtests run 
t/02inflate.t .... perl: utf8.c:72: Perl_force_out_malformed_utf8_message_: Assertion `p < e' failed.
t/02inflate.t .... No subtests run 

Test Summary Report
-------------------
t/01downgrade.t (Wstat: 134 (Signal: ABRT, dumped core) Tests: 0 Failed: 0)
  Non-zero wait status: 134
  Parse errors: No plan found in TAP output
t/02inflate.t  (Wstat: 134 (Signal: ABRT, dumped core) Tests: 0 Failed: 0)
  Non-zero wait status: 134
  Parse errors: No plan found in TAP output
Files=2, Tests=0,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.06 cusr  0.02 csys =  0.10 CPU)
Result: FAIL
Failed 2/2 test programs. 0/0 subtests failed.

I was also unable to install GD-Persian (GH #24231), but a test failure in prerequisite GD (lstein/Perl-GD#62) is implicated here.

[khwilliamson]

The requested list of reverts understandably didn't include a merge commit that I made instead of a PR. I have now reverted that, and verified that Biblio:SICI works. I didn't check the other failures.

[jkeenan]

The requested list of reverts understandably didn't include a merge commit that I made instead of a PR. I have now reverted that, and verified that Biblio:SICI works. I didn't check the other failures.

Building a local threaded, debugging perl based on the updated status of this branch, I get:

./bin/perl -Ilib \
-MApp::CPAN::Mini::Visit \
-MProc::Async \
-MBiblio::SICI \
-MString::Equivalence::Amharic \
-E 'say q{hello world};'

I can also install GD::Persian provided that I force install GD so as to ignore the test failure in that distro.