test: update load test for deeper paths and newer schema version#2915
test: update load test for deeper paths and newer schema version#2915omer-topal merged 1 commit intomasterfrom
Conversation
📝 WalkthroughWalkthroughPerformance documentation is updated with new load-test metrics and k6 test scripts. The target Permify version is updated to 1.6.9. A dedicated Write Script is introduced to seed large data volumes, and the read/check script is modified to improve ID tracking and randomization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/performance-test/README.md`:
- Line 267: The table row for the metric "http_req_connecting" contains a typo
in the percentile column: "p(95=0s" is missing a closing parenthesis; update
that token to "p(95)=0s" so the row reads "| **http_req_connecting** |
avg=2.57µs min=0s med=0s max=2.04ms p(90)=0s p(95)=0s
|", ensuring the p(95) notation matches the others.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 128fa534-6503-4861-a8c2-6dbc57bd833b
📒 Files selected for processing (2)
README.mddocs/performance-test/README.md
| | **data_sent** | 27 MB (268 kB/s) | | ||
| | **dropped_iterations** | 272433 (2696.482348/s) | | ||
| | **http_req_blocked** | avg=5.59µs min=0s med=2µs max=2.08ms p(90)=4µs p(95)=5µs | | ||
| | **http_req_connecting** | avg=2.57µs min=0s med=0s max=2.04ms p(90)=0s p(95=0s | |
There was a problem hiding this comment.
Fix typo in p(95) percentile notation.
Missing closing parenthesis in p(95=0s - should be p(95)=0s to match the formatting in other rows.
📝 Proposed fix
-| **http_req_connecting** | avg=2.57µs min=0s med=0s max=2.04ms p(90)=0s p(95=0s |
+| **http_req_connecting** | avg=2.57µs min=0s med=0s max=2.04ms p(90)=0s p(95)=0s |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | **http_req_connecting** | avg=2.57µs min=0s med=0s max=2.04ms p(90)=0s p(95=0s | | |
| | **http_req_connecting** | avg=2.57µs min=0s med=0s max=2.04ms p(90)=0s p(95)=0s | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/performance-test/README.md` at line 267, The table row for the metric
"http_req_connecting" contains a typo in the percentile column: "p(95=0s" is
missing a closing parenthesis; update that token to "p(95)=0s" so the row reads
"| **http_req_connecting** | avg=2.57µs min=0s med=0s max=2.04ms
p(90)=0s p(95)=0s |", ensuring the p(95) notation matches the
others.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2915 +/- ##
==========================================
+ Coverage 81.98% 82.57% +0.60%
==========================================
Files 74 74
Lines 11215 8300 -2915
==========================================
- Hits 9193 6853 -2340
+ Misses 1486 911 -575
Partials 536 536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit