test: apply track_commit_timestamp via Cmd to skip postgres restart

[omer-topal]

Summary by CodeRabbit

• Chore
  • Simplified PostgreSQL test database initialization by passing configuration flags directly at container startup, removing an earlier multi-step approach. This streamlines the test setup process with fewer operations required during database initialization.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7d2f0f18-0281-4fce-baab-2df349ef04a7

📥 Commits

Reviewing files that changed from the base of the PR and between 78e2cfb and 26af8d8.

📒 Files selected for processing (1)

• pkg/testinstance/postgres.go

---

📝 Walkthrough

Walkthrough

The PostgreSQL test container initialization is simplified by moving from a runtime configuration approach (in-container ALTER SYSTEM with container restart) to a startup flag approach (-c track_commit_timestamp=on). This eliminates unnecessary container manipulation and schema resets during test setup.

Changes

PostgreSQL Test Container Initialization

Layer / File(s)	Summary
Startup Configuration pkg/testinstance/postgres.go	Container Cmd is configured to pass track_commit_timestamp=on directly to the PostgreSQL server at startup.
Removed Legacy Initialization pkg/testinstance/postgres.go	The in-container psql ALTER SYSTEM execution, container stop/restart sequence, and public schema reset via DROP/CREATE SCHEMA are removed.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly Related PRs

• Permify/permify#2950: Also modifies pkg/testinstance/postgres.go for PostgreSQL test container startup and configuration.

Poem

🐰 A rabbit hops through startup flags so bright,
No more restarts in the container night!
track_commit_timestamp now boots with grace,
Simpler init, a cleaner test space! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: applying track_commit_timestamp via the Cmd flag to skip a postgres restart, which aligns with the code modification shown in the summary.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/postgres-test-skip-restart

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.58%. Comparing base (78e2cfb) to head (26af8d8).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
+ Coverage   82.57%   82.58%   +0.02%     
==========================================
  Files          74       74              
  Lines        8300     8300              
==========================================
+ Hits         6853     6854       +1     
+ Misses        911      910       -1     
  Partials      536      536              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.