feat(web): aha-highlight the first agent-created item (TASK-1853)#745
Merged
Conversation
Closes the sprint-to-aha loop for the onboarding bridge: when an agent creates the first real item during onboarding, its dashboard card gets a "✨ your agent just created this" badge + accent, so value lands visibly for the human in the live launchpad→board handoff. Detection is a slug-keyed effect on needs_onboarding: when it flips true→false within the same workspace (driven by the existing SSE→sync→load path), the current active_items slugs are captured and their cards highlighted for the session. Scoped tightly to the live transition — a later page load (needs_onboarding already false) fires no transition, so routine creates are never highlighted; the slug key prevents a workspace switch from false-positiving. Satisfies CONVE-1688 (the effect writes justCreatedSlugs but never reads it) and CONVE-606 (untrack-wrapped, route-change-aware). Parent: PLAN-1847 (Phase 2, task C). Claude-Session: https://claude.ai/code/session_01KmxkPxLksjf1pmrZDpsnTJ
…, per Codex review (round 1) Round-1 review caught a workspace-switch race: a silent reload leaves the old dashboard (needs_onboarding=true) in state while wsSlug already flipped, so the route-keyed edge recorded onboarding=true under the new slug and then false-positived when the new workspace's data (false) arrived — highlighting all of the new workspace's items. Stamp the dashboard with the slug it was fetched for (dashboardSlug) and key the transition on that. The true→false edge is now only ever computed across two loads of the SAME workspace's data. Claude-Session: https://claude.ai/code/session_01KmxkPxLksjf1pmrZDpsnTJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the sprint-to-aha loop for the onboarding bridge: when an agent creates the first real item during onboarding, its dashboard card gets a "✨ your agent just created this" badge + accent — so value lands visibly for the human in the live launchpad→board handoff.
Detection is a slug-keyed effect on
needs_onboarding: when it flipstrue→falsewithin the same workspace (driven by the existing SSE→sync→load path), the currentactive_itemsslugs are captured and their cards highlighted for the session.Scoped tightly to the live transition: a later page load (
needs_onboardingalready false) fires no transition, so routine item creation is never highlighted; the slug key prevents a workspace switch from false-positiving.Satisfies CONVE-1688 (the effect writes
justCreatedSlugsbut never reads it) and CONVE-606 (untrack-wrapped, route-change-aware).Context
Implements
TASK-1853underPLAN-1847(Phase 2, task C) — the final Phase 2 task. Completes the full Phase 2 launchpad vision.Test plan
https://claude.ai/code/session_01KmxkPxLksjf1pmrZDpsnTJ