fix(web): exact-pin coordinated Tiptap packages + CI drift guard (BUG-2009)#838
Merged
Conversation
…-2009) CLAUDE.md mandates exact-pinning the coordinated Tiptap packages so npm cannot silently slide the shared Y.Doc/ProseMirror schema out of sync. @tiptap/core (^3.22.5), @tiptap/y-tiptap (^3.0.3) and @tiptap/pm (^3.20.4) were still floating on caret ranges; only @tiptap/extension-collaboration was exact. - Exact-pin @tiptap/core, @tiptap/y-tiptap and @tiptap/pm to their currently-resolved versions (3.22.5 / 3.0.3 / 3.22.5); refresh lockfile. - Add web/scripts/check-tiptap-pins.mjs + check:tiptap-pins npm script: fails if any coordinated package loses its exact pin in package.json or resolves to more than one version in the lockfile. - Wire the guard into the CI web job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG-2009
CLAUDE.md ("Tiptap multi-package coordinated bumps") mandates exact-pinning the coordinated Tiptap packages so
npm updatecannot silently slide the shared Y.Doc/ProseMirror schema out of sync (divergent collab ops the relay can't reconcile). In practice@tiptap/core(^3.22.5),@tiptap/y-tiptap(^3.0.3) and@tiptap/pm(^3.20.4) were still on caret ranges — only@tiptap/extension-collaborationwas exact. The lockfile was coherent today but anynpm updatewould slide it.Changes
@tiptap/core→3.22.5,@tiptap/y-tiptap→3.0.3,@tiptap/pm→3.22.5(their currently-resolved versions; no resolved-version change, lockfile only lost the three caret chars).web/scripts/check-tiptap-pins.mjs(+npm run check:tiptap-pins): fails if any of the four coordinated packages loses its exact pin in package.json OR resolves to more than one version in the lockfile.webjob right afternpm ci.Verification
npm run check:tiptap-pins→ OK (4 packages exact-pinned and single-versioned); negative-tested that a caret pin makes it exit 1.npm run check→ 0 errors;npm run build→ green.npm audit --audit-level=high --omit=devstill exits 0 (unchanged).