Skip to content

fix(cli): wrap comment not-found errors with item context #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xarmian merged 1 commit into from
Jul 11, 2026
Merged

fix(cli): wrap comment not-found errors with item context #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/cli/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,8 @@ func (c *Client) ListComments(wsSlug, itemSlug string) ([]models.Comment, error)

func (c *Client) CreateComment(wsSlug, itemSlug string, input models.CommentCreate) (*models.Comment, error) {
var result models.Comment
return &result, c.post("/workspaces/"+wsSlug+"/items/"+itemSlug+"/comments", input, &result)
err := c.post("/workspaces/"+wsSlug+"/items/"+itemSlug+"/comments", input, &result)
return &result, wrapItemNotFound(err, itemSlug, wsSlug)
}

func (c *Client) DeleteComment(wsSlug, commentID string) error {
Expand Down
3 changes: 3 additions & 0 deletions internal/cli/item_notfound_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ func TestGetItemWrapsNotFound(t *testing.T) {
if err := client.DeleteItem("docapp", "TASK-999999"); err == nil || err.Error() != want {
t.Errorf("DeleteItem: got %v, want %q", err, want)
}
if _, err := client.CreateComment("docapp", "TASK-999999", models.CommentCreate{Body: "test"}); err == nil || err.Error() != want {
t.Errorf("CreateComment: got %v, want %q", err, want)
}
}

// TestNotFoundPreservesDetails confirms the enriched *APIError carries the
Expand Down