[codex] runtime descriptor metadata for Math and generators - #4149
Merged
proggeramlug merged 1 commit intoJun 3, 2026
Merged
Conversation
andrewtdiz
force-pushed
the
codex/node-compat-runtime-descriptors
branch
from
June 2, 2026 19:30
fa24334 to
2ed014f
Compare
proggeramlug
force-pushed
the
codex/node-compat-runtime-descriptors
branch
from
June 3, 2026 06:07
2ed014f to
51b75da
Compare
proggeramlug
marked this pull request as ready for review
June 3, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Behavior Cluster
This is a focused runtime descriptor cut for builtin reflective metadata:
Mathown methods and constants with Node-compatible data-property attributesMath.<method>reads through the realMathnamespace object so methodname/lengthdescriptors remain observableMath,JSON, andReflectas builtin global values so bare namespace reads lower throughglobalThisSymbol.toStringTagvalues inObject.prototype.toString, covering generator constructor reflectionWhy Batched
#4139 and #4141 both fail in the same reflective surface: builtin own-property descriptors and intrinsic prototype metadata. The implementation path is shared across global namespace installation, object descriptor lookup, and codegen member reads, and the tests use the same
node-suite/globalsparity harness.Tests Added
test-parity/node-suite/globals/builtin-namespace-descriptors.tstest-parity/node-suite/globals/generator-prototype-descriptors.tsValidation
cargo build --release -p perry-runtime -p perryPERRY_NO_AUTO_OPTIMIZE=1 PERRY_ALLOW_UNIMPLEMENTED=1 target/release/perry compile --no-cache test-parity/node-suite/globals/builtin-namespace-descriptors.ts -o /tmp/perry_builtin_namespace_descriptors && /tmp/perry_builtin_namespace_descriptorsPERRY_NO_AUTO_OPTIMIZE=1 PERRY_ALLOW_UNIMPLEMENTED=1 target/release/perry compile --no-cache test-parity/node-suite/globals/generator-prototype-descriptors.ts -o /tmp/perry_generator_prototype_descriptors && /tmp/perry_generator_prototype_descriptorsPATH=/tmp/perry-node25-bin:$PATH PERRY_NO_AUTO_OPTIMIZE=1 PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module globals --filter builtin-namespace-descriptorsPATH=/tmp/perry-node25-bin:$PATH PERRY_NO_AUTO_OPTIMIZE=1 PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module globals --filter generator-prototype-descriptorscargo test -p perry-runtime objectcargo fmt --all -- --checkgit diff --checkgit diff --check HEAD./scripts/check_file_size.shKnown Limitations
Maththunks added here are sufficient for descriptor-visible escaped method values, but this PR is not a full Math semantics audit.Non-Goals