[codex] Align primitive wrapper receivers#4161
Merged
proggeramlug merged 2 commits intoJun 3, 2026
Merged
Conversation
This was referenced Jun 2, 2026
Open
…e-dispatch thunk The top-of-string-branch interception in js_native_call_method re-entered itself through the PerryTS#4100 brand-check re-dispatch thunk installed on String.prototype (e.g. replace), overflowing the stack. User-defined prototype methods on primitive receivers are still routed through the primitive_kind fallback after native dispatch.
proggeramlug
force-pushed
the
codex/node-compat-primitive-wrappers
branch
from
89aba45 to
f868104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thiswithout persisting expando writesValidation
PATH="/tmp/perry-node25-bin:$PATH" ./run_parity_tests.sh --suite node-suite --module object --filter primitive-wrapper-toobjectPATH="/tmp/perry-node25-bin:$PATH" ./run_parity_tests.sh --suite node-suite --module globals --filter json-boxed-primitive-wrappersPATH="/tmp/perry-node25-bin:$PATH" ./run_parity_tests.sh --suite node-suite --module util --filter boxed-primitivescargo build -p perry-runtime -p perry-hir -p perry-codegen -p perrycargo fmt --all -- --checkgit diff --check HEAD./scripts/check_file_size.sh