[codex] Respect symbol enumerability in Object.assign#4239
Merged
proggeramlug merged 1 commit intoJun 3, 2026
Conversation
a549a9b to
0538a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3986.
Summary
Object.defineProperty.Object.getOwnPropertyDescriptor.Object.assignskip non-enumerable symbol data properties while preserving direct-assignment defaults.Why This Cut
#4161 handled the Object boxing portion of #3986. This PR covers the remaining coherent
Object.assigndescriptor/copy tail: the same symbol descriptor metadata is needed both for descriptor round-trips and for deciding whether a symbol property is enumerable during assignment.Tests
CARGO_TARGET_DIR=/root/perry-worktrees/perry-object-assign-tail/target cargo test -p perry-runtime symbol_define_property_attrs_round_trip_descriptorCARGO_TARGET_DIR=/root/perry-worktrees/perry-object-assign-tail/target cargo check -p perry-runtime -p perry-stdlib -p perryCARGO_TARGET_DIR=/root/perry-worktrees/perry-object-assign-tail/target npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module object --filter assign'cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shNon-Goals
getOwnPropertyDescriptorbehavior needed for this Object.assign cut.