[codex] fix HTTP external symbol linking#4216
Merged
proggeramlug merged 1 commit intoJun 3, 2026
Merged
Conversation
Register emitted HTTP and net wrapper symbols with their well-known owners so native-table calls pull the correct static libraries. Keep well-known prebuilt wrapper resolution active when PERRY_NO_AUTO_OPTIMIZE skips stdlib specialization, and force-retain HTTP server symbols in libperry_ext_http.a.
9bc4e5d to
b1242c1
Compare
This was referenced Jun 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the HTTP compile/linking portion of #3954.
node:http/node:httpsclient and server wrapper symbols with thehttpwell-known owner so native-table lowering pullsperry-ext-httpinto the link line.netwell-known owner soperry-ext-netis linked for those emitted symbols.PERRY_NO_AUTO_OPTIMIZE=1, while still letting runtime/stdlib fall back to the prebuilt full archives.perry-ext-httpforce-link anchor so the archive retains newer HTTP server/IncomingMessage/ServerResponse entry points.Validation
cargo fmt --all -- --checkcargo test -p perry-codegen emitted_http_suite_external_symbols_route_to_owners -- --nocapturecargo build --release --quiet -p perry -p perry-runtime -p perry-stdlib -p perry-ext-http -p perry-ext-netgit diff --check./scripts/check_file_size.shPERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module http'v26.3.05parity pass /12parity fail /0compile fail /0skippedtest-parity/reports/parity_report_20260603_055225.jsonnm -g target/release/libperry_ext_http.aspot-checks show representative HTTP symbols present.nm -g target/release/libperry_ext_net.aspot-checks show representative net socket listener symbols present.