perf(runtime): drain nextTick queue with VecDeque::pop_front (was O(n²))#6126
Merged
Conversation
… O(n²)) QUEUED_MICROTASKS was a Vec drained with `remove(0)` — O(n) per job, so a burst of n queued nextTick jobs (common under Node stream / 'readable' scheduling) memmoved ~n²/2 entries. Switch to VecDeque + push_back/pop_front for O(1) drain. FIFO order and same-drain visibility of jobs enqueued during the drain are unchanged (verified vs node: ordering + a 1000-job burst). #6084.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe internal microtask queue backing ChangesMicrotask Queue VecDeque Migration
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the #6084 server-scalability quadratics.
Problem
QUEUED_MICROTASKS(theprocess.nextTickqueue) was aVecdrained withqueue.remove(0), which is O(n) per job — so draining a burst of n nextTick jobs (common under Node stream /'readable'scheduling) memmoves ~n²/2 entries.Fix
Use
VecDequewithpush_back/pop_frontfor O(1) drain — the same structure the promiseTASK_QUEUEalready uses.Behavior
Unchanged: FIFO order and same-drain visibility of jobs enqueued during the drain. Verified vs
node --experimental-strip-types:nextTickordering (1,2,3incl. a job queued inside a job) and a 1000-job burst both match.Summary by CodeRabbit
queueMicrotaskandprocess.nextTick, reducing queue draining overhead and making scheduling more efficient.