Skip to content

refactor(http): remove bundled Node HTTP client#6835

Merged
proggeramlug merged 3 commits into
refactor/merge-http-server-into-httpfrom
refactor/remove-stdlib-http-client
Jul 25, 2026
Merged

refactor(http): remove bundled Node HTTP client#6835
proggeramlug merged 3 commits into
refactor/merge-http-server-into-httpfrom
refactor/remove-stdlib-http-client

Conversation

@TheHypnoo

Copy link
Copy Markdown
Member

Summary

  • delete the duplicate perry-stdlib Node HTTP/HTTPS/HTTP2 implementation
  • keep perry-ext-http as the sole Node HTTP implementation
  • retain Web Fetch, Axios, common::dispatch_http, and both external HTTP pumps
  • keep the 215-symbol selected perry-ext-http ABI

Evidence

  • Removed 2,634 Rust source lines across the four bundled HTTP files.
  • Release llvm-nm: 215 selected HTTP symbols in libperry_ext_http.a; no selected definitions in libperry_stdlib.a; zero overlap.
  • Release archives: libperry_ext_http.a 74,246,528 bytes; libperry_stdlib.a 72,631,024 bytes.
  • Optimized compile smoke for test-files/test_node_http_basic.ts linked and wrote /tmp/perry-phase4-http.

Tests

  • cargo check -p perry-stdlib --no-default-features --features web-fetch
  • cargo check -p perry-stdlib --no-default-features --features http-client
  • cargo test -p perry --bin perry commands::stdlib_features::tests::
  • cargo test -p perry --bin perry commands::compile::optimized_libs::tests::
  • cargo build --release -p perry-ext-http -p perry-stdlib-static

Known inherited failure

Scope

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a9fc85b8-b68a-4f23-a84c-d00068e90d25

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-stdlib-http-client

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from refactor/http-ffi-boundary to refactor/merge-http-server-into-http July 25, 2026 19:07
@proggeramlug
proggeramlug merged commit d77062e into refactor/merge-http-server-into-http Jul 25, 2026
3 checks passed
@proggeramlug
proggeramlug deleted the refactor/remove-stdlib-http-client branch July 25, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants