ci(lint): let every gate report instead of stopping at the first failure - #7306
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe lint workflow now runs independent validation gates unless the job is cancelled. Setup steps remain failure-blocking. A changelog entry documents the execution and reporting behavior. ChangesLint gate reporting
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One failing
lintstep hides every step after it. Before this change, 1 of 17 steps ran unconditionally.This is not hypothetical — it is how four gates went unexecuted for 40+ commits
The public-baseline freshness check sits at step 8. While it was stale, everything below it never ran in CI at all:
!cancelled(), so it survivedBecause
lintis a required context, the visible effect was that every merge needed--adminand branch protection became theatre. The invisible effect was worse: six gates reporting nothing, indistinguishable from six gates passing.The change
if: ${{ !cancelled() }}on all 11 gate steps. Setup steps (checkout, Node, Rust toolchain) still stop the job — there is nothing to gate without a toolchain.The job still fails if any gate fails. This changes reporting, not strictness.
Why now
The benchmark artifact is expected to go stale repeatedly during the current optimization work — its only fix is a ~2-hour regeneration on a specific quiet host (#7282 tracks narrowing the trigger). Accepting a stale artifact is a reasonable trade; silently disarming six unrelated gates every time it happens is not.
CI-only. No behaviour change.
Summary by CodeRabbit
Bug Fixes
Documentation