docs: rename two changelog fragments to their real PR numbers - #7386
Merged
Conversation
I wrote both fragments before opening their PRs and guessed the next number, so each was off by one: the mirror-remaining-sites work is #7383 (not 7382) and the size-arm rooting is #7385 (not 7384). 7384 is worse than cosmetic -- it is an open PR by another author, so the fragment claimed a number already in use and would have collided when that PR adds its own. Fragment names are PR-keyed precisely so in-flight PRs never collide; guessing the number defeats that. Open the PR first, then name the fragment.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote both fragments before opening their PRs and guessed the next number, so each is off by one:
7382-mirror-remaining-sites.md→ fix(gc): refresh obj at the remaining six class-static mirror sites #73837384-size-arm-rooting.md→ fix(gc): root the receiver across the .size arm's three allocating helpers #7385The second is worse than cosmetic: #7384 is an open PR by another author, so my fragment claimed a number already in use and would have collided when that PR adds its own.
Fragment names are PR-keyed precisely so in-flight PRs never collide — guessing the number defeats the mechanism. Open the PR first, then name the fragment.