fix(gc): restore the raw-handle debt baseline after #7693 - #7704
Merged
Conversation
added 2 commits
August 9, 2026 15:06
#7693's test asserts a pre/post address comparison, the shape across_* exists to make unnameable, so it is listed rather than converted. Four pairs converted elsewhere to hold the baseline at 998. Claude-Session: https://claude.ai/code/session_01Y1QZ5wUP9gRSwpiweT4Wix
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe runtime now refreshes movable pointers across allocation-triggered GC activity. Raw-handle debt ceilings and changelog records were updated. Workspace version references were incremented from ChangesRaw handle debt reduction
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(gc): restore the raw-handle debt baseline after #7693, and convert four pairs to pay for it.#7693's regression test asserts a sentinel's pre/post address comparison — which is precisely what
across_*exists to make unnameable, so converting its four reads would delete the test's subject. It joinsjson_shape_template.rsas the second instance of that permitted shape.raw_handle_debt_files.txtallows listing only when the same change converts enough pairs elsewhere that the global baseline does not rise. Four converted, each a genuine read-after-allocating-call:os.rs—js_object_alloc_with_shape+ thetimesre-read (ceiling 4 → 3)util_parse_args.rs—js_string_from_bytes+ thevaluesre-read (20 → 19)weakref.rs—entries_array(itself allocating) + theentryre-read (7 → 6)regex/match_all.rs—build_match_all_groups_owned+ the inner-array re-read (14 → 13)Net 998 → 998, 110 modules within ceilings.
Also converts three
weakref.rsjs_string_from_bytes+ registry-re-read sites toacross_nanbox. Those do not move the counter — it matches only.get_raw_{mut,const}_ptr— but they are the same defect and the same fix, and leaving them because they are invisible to the ratchet would be optimising for the metric.Summary by CodeRabbit
Bug Fixes
Documentation
Chores