fix(opt-report): report Ptr<Shape> provenance prefilters (#7112) - #7870
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesPtr Shape reporting
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
let = newcandidates rejected because their binding is boxed or module-global--opt-reportrecording is enabledThis completes the Ptr half left explicitly untouched by #7819, which covered the Ptr prefilters.
Reproduction
On clean
main, the new collector test failed because a boxed allocation and a module-global allocation produced an empty report even though both are recognizable shape candidates. With this change, each produces exactly one local denial naming its prefilter, while neither is promoted.Validation
cargo test -p perry-codegen provenance_prefilters_report_boxed_and_module_global_new_bindings(1 passed)cargo test -p perry-codegen --lib(890 passed, 0 failed)python3 scripts/check_test_registration.py(195 files, 4 registries)bash scripts/check_file_size.shCloses #7112
Summary by CodeRabbit
New Features
--opt-reportto include boxed and module-globalPtr<Shape>candidates.Bug Fixes