fix(gc): isolate class heap registries per agent (#8001) - #8024
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
left a comment
There was a problem hiding this comment.
Audited commit b2842e5 against current main. The ownership split is correct: heap pointers, NaN-boxed values, closure identities, and realm Symbol keys are agent-local, while code-only metadata remains global. The full and incremental root paths now scan only the current agent. Independent verification: release two-agent prototype regression passed; class side-table mark/rewrite, copying-minor value/key rewrite, Symbol-key rewrite, inheritance-root rewrite, and foreign-clear isolation regressions all passed. global_sink_isolation.py, gc_runtime_root_holders.py, check_file_size.sh, diff check, and current-main merge-tree check are clean. No blocking findings.
Summary
Isolates class-registry entries that contain heap pointers, NaN-boxed values, closure identities, or realm-created Symbol keys per Perry agent. This prevents a later perry/thread agent from reusing another realm heap values and prevents one moving collector from rewriting another agent roots.
Changes
Related issue
Closes #8001
Test plan
The repository quick pre-tag suite otherwise passed, but its GC store-site inventory reports an existing marker omission at crates/perry-codegen/src/expr/property_set.rs:1457. That file is unchanged by this PR.
Screenshots / output
The new parity probe prints:
Checklist