Skip to content

style(array): restore rustfmt on the files #8090 landed unformatted - #8107

Merged
proggeramlug merged 1 commit into
mainfrom
fix/8090-fmt-regression
Aug 14, 2026
Merged

style(array): restore rustfmt on the files #8090 landed unformatted#8107
proggeramlug merged 1 commit into
mainfrom
fix/8090-fmt-regression

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

cargo fmt --all -- --check is red on main at 0d7fe21b0, in exactly the two files #8090 touched — the array::header re-export list in array/mod.rs and the import block in typed_array_receiver_tests.rs.

lint is a required context and #8087 had only just restored it, so this put it back to red for every open PR, one day after #8092 documented that pattern.

Formatting only. No code change, no change to the re-export set. cargo fmt --all -- --check is clean afterwards, and the other four gates (check_file_size.sh, gc_store_site_inventory.py, raw_handle_debt.py, addr_class_inventory.py) were already green and stay green.

Mine to own: I merged #8090 after running those four static gates on the landing tree and did not run cargo fmt --check, which is the one that catches this. Refs #8092.

Summary by CodeRabbit

  • Style
    • Reformatted internal array imports and test assertions for improved readability.
    • Reordered internal declarations without changing functionality or observable behavior.

`cargo fmt --all -- --check` is red on main at 0d7fe21, in exactly the
two files that commit touched: the `array::header` re-export list in
`array/mod.rs` and the import block in `typed_array_receiver_tests.rs`.

`lint` is a required context and #8087 had just restored it, so this put
it straight back to red for every open PR. Formatting only -- no code,
no re-export set change, `cargo fmt --all -- --check` clean afterwards.

My fault at merge time: I ran the four static gates (file size, GC
store-site inventory, raw-handle ratchet, addr-class inventory) on the
landing tree and did not run `cargo fmt --check`, which is the one gate
that catches this.
@proggeramlug
proggeramlug merged commit b3b6f17 into main Aug 14, 2026
31 of 54 checks passed
@proggeramlug
proggeramlug deleted the fix/8090-fmt-regression branch August 14, 2026 22:27
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 89b88499-ae31-49f4-8bca-9ab8dfcd7c30

📥 Commits

Reviewing files that changed from the base of the PR and between 0d7fe21 and a028c7d.

📒 Files selected for processing (2)
  • crates/perry-runtime/src/array/mod.rs
  • crates/perry-runtime/src/array/typed_array_receiver_tests.rs

📝 Walkthrough

Walkthrough

Changes

Array formatting cleanup

Layer / File(s) Summary
Array exports and receiver test formatting
crates/perry-runtime/src/array/mod.rs, crates/perry-runtime/src/array/typed_array_receiver_tests.rs
The header re-exports are reordered. Array imports and the copyWithin receiver assertion use multiline formatting. Exported identifiers and behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: jdalton, thehypnoo

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/8090-fmt-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant