ci: exclude the fastify doc snippets from the no-auto doc-tests run (#8475) - #8476
Merged
Merged
Conversation
getting-started/npm_packages.ts, stdlib/http/fastify_json.ts and stdlib/overview/snippets.ts all import fastify, and run_doc_tests sets PERRY_NO_AUTO_OPTIMIZE=1 for host runs. perry compile deliberately hard-errors on 'import fastify' under that flag: the prebuilt stdlib is not built with external-fastify-pump, so the request loop would hang. All three are therefore COMPILE_FAIL in doc-tests, which gates the release. Exclude them on the same terms as stdlib/http/snippets.ts, already excluded for a sibling no-auto routing reason. This is an EXPLICIT COVERAGE GAP, not a fix: those snippets are now unverified by CI. #8475 tracks closing it, and records that the guard keys on the env var alone — I verified that building perry-stdlib-static --features perry-stdlib/external-fastify-pump does NOT satisfy it, so enabling the feature in the prebuild is not a fix by itself. Refs #8475
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe macOS and Windows ChangesFastify documentation-test exclusions
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #8475 — the last three known
doc-testsCOMPILE_FAILs blocking the release gate.All three import fastify, and the harness sets
PERRY_NO_AUTO_OPTIMIZE=1for host runs;perry compiledeliberately refusesimport 'fastify'under that flag because the prebuilt stdlib lacksexternal-fastify-pumpand the request loop would hang. Excluded on the same terms asstdlib/http/snippets.ts, already excluded for a sibling reason.This is an explicit coverage gap, not a fix. Those three snippets are now unverified by CI. #8475 tracks closing it and lists three candidate real fixes (a second auto-optimizing pass for just this class — probably the best value; a self-describing
// requires:harness directive; or making the guard inspect the archive rather than the env var).One finding worth recording: the guard keys on the environment variable alone and never inspects the archive — I verified that building
perry-stdlib-static --features perry-stdlib/external-fastify-pumpdoes not satisfy it, so 'just enable the feature in the doc-tests prebuild' would not have worked.Summary by CodeRabbit
Documentation
Tests