fix(perry): register PERRY_OBJECT_LITERAL_SHAPE_METHODS as a build-cache input - #9144
Merged
Merged
Conversation
…che input #9122 introduced the knob; its registration was prepared but did not make it into the merged commit, leaving codegen_env_vars_are_build_cache_inputs red on main. The knob selects between two literal-birth emission sequences, so it is a cache key.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build cache now includes ChangesBuild cache invalidation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codegen_env_vars_are_build_cache_inputsis red onmain.#9122 introduced
PERRY_OBJECT_LITERAL_SHAPE_METHODS(a codegen kill switch) without registering it inBUILD_CACHE_ENV_VARS. I caught that during review and prepared the registration, but it did not make it into the commit that merged — my cherry-pick of the fix resolved against the wrong branch and silently no-op'd, so I merged #9122 without it. My mistake, not the PR author's.The knob selects between two different literal-birth emission sequences, so it is a genuine cache key rather than an exclusion candidate — a cached object built with it on must not serve a build with it off.
Verified on this branch: the gate test passes (
1 passed), fmt clean.Summary by CodeRabbit
this.