fix(runtime): restore hot TLS for arena right-sizing - #9736
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe change switches arena right-size state declarations to the runtime thread-local macro and updates the changelog with MB-based measurements and revised capacity and RSS results. ChangesArena right-sizing
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This follow-up routes arena right-sizing state through the runtime TLS mechanism and corrects measurement labels to MB. No merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-up to #9731, which landed through merge train #9735. The train was assembled before the final two reviewed branch commits, so it retained a raw
thread_local!declaration and mislabeled decimal byte measurements as MiB.Closes #9709.
Validation
cargo fmt --all -- --checkcargo check -p perry-runtimecargo test -p perry-runtime --lib gc::tests::arena_right_size -- --test-threads=1(5 passed)cargo test -p perry-runtime --lib gc::tests::idle_reclaim -- --test-threads=1(12 passed)python3 scripts/check_thread_locals.py --self-testgc/arena_right_size.rsis reported on landedmainand absent with this patch; remaining reports are pre-existing files onmainRelease checklist
Cargo.toml,Cargo.lock,CLAUDE.md, orCHANGELOG.mdchangeSummary by CodeRabbit