fix(cache): register concat switch and explain codegen inputs - #9748
fix(cache): register concat switch and explain codegen inputs#9748proggeramlug wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe build cache now includes ChangesCodegen cache registration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Changing PERRY_CONCAT_SITE_CACHE now invalidates build-cache entries, preventing cached generated output from being reused across incompatible settings. The accompanying validation guidance and documentation are aligned, with no remaining merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on |
New codegen switches repeatedly miss build-cache registration because the failing test names the constants but does not identify their source file. The failure now names
crates/perry/src/commands/compile/build_cache.rs, both declaration anchors, why registration matters, and the exact test command to rerun. Contributor guidance and the OnceLock reader example carry the same requirement.Running the gate found another omission on current main:
PERRY_CONCAT_SITE_CACHE. It emits/removes per-site concatenation tables, so it now participates in the build-cache key. The existing missing-input and stale-exclusion checks remain intact. No version bump.Validation:
cargo test --profile perry-dev -p perry --bin perry codegen_env_vars_are_build_cache_inputspasses.commands::compile::build_cache::testspass.Fixes #9158.
Summary by CodeRabbit
Bug Fixes
Documentation