fix(trace_events): align descriptors and empty filters - #9884
fix(trace_events): align descriptors and empty filters#9884proggeramlug wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe ChangesTrace events alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This aligns trace-event export descriptors, category parsing, and marker emission with Node behavior. The changes preserve enabled tracing metadata and avoid emitting markers for unrelated categories, with no current merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on |
Two
trace_eventsrows in the #9202 Node-suite audit remain reproducibly red. Perry marks the module namespace exports configurable, while Node exposes writable/enumerable/non-configurable bindings. Perry also treats the literal CLI argument""as an enabled category and emits an application event, while Node writes metadata only for that empty selection.This makes both named and default trace-events namespace bindings non-configurable, normalizes a quoted empty category list, and emits the synthetic application marker only for the implemented
node,node.bootstrap, andnode.consolecategories. Non-empty and legacy category behavior is preserved.Validation:
node-suite/trace_events/surface/module-descriptors: 1/1 parity pass against Node 26.5.1 on the final rebased headnode-suite/trace_events/native-output/category-filtering: 1/1 parity pass on the final rebased headdisable-filter,file-shape-exit, andpre-enabled-categoriesfixtures: exact Node outputcargo test -p perry-runtime -- --test-threads=1: 3,215 passed, 4 ignored; doc tests greenscripts/run_lint_gates.sh: all 64 gates passed; 2 CI-expression gates skipped locallyNo version bump.
Addresses the two
trace_eventsrows in #9202.Summary by CodeRabbit
Bug Fixes
node:trace_eventscompatibility by aligning export property behavior with Node.js.included-markerevent when no relevant Node categories are enabled.Documentation
node:trace_eventsbehavior.