Skip to content

Bug: DynamicCollector states_di order disagrees with packed state order #141

Description

@bernalde

Parent: #118

Problem

DynamicCollector.states_di declares mass, mass_frac, temp, while the implementation packs and unpacks mass_frac, mass, temp. Manual slicing hides the mismatch and metadata-driven unpacking would silently misassign values.

Acceptance criteria

  • Add a regression test comparing metadata-driven and implementation state ordering.
  • Make states_di, initial packing, model unpacking, and result retrieval agree.
  • Preserve numerical behavior apart from correcting the ordering contract.
  • Keep this bug fix isolated from the wider StateLayout refactor.

Metadata

Metadata

Assignees

Labels

area:containersMixer, collector, holdup, and container unit operationsbugSomething isn't workingcorrectnessModel/numerical correctness defectrefactor:mpvOverlaps the MultiPhaseVessel refactor; revalidate after mergeseverity:highConfirmed bug with major correctness impact or broken documented workflowstatus:verifiedSource-reviewed against the current codebase

Type

Projects

Status
No status

Relationships

None yet

Development

No branches or pull requests

Issue actions