You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Grow real test coverage beyond the two existing integration scenarios, with an emphasis on fast unit tests that don't need assimulo. Part of #3; depends on #4.
Many pure-Python pieces are unit-testable in isolation without a solver: kinetics rate evaluation, thermodynamic property calls, stream/phase construction, name analysis, interpolation, FVM flux/limiter helpers, moment conversions.
Goal
Grow real test coverage beyond the two existing integration scenarios, with an emphasis on fast unit tests that don't need assimulo. Part of #3; depends on #4.
Current state
Proposed coverage targets (unit, no assimulo)
Kinetics.py—RxnKinetics.get_rxn_rates/temp_term/elem_f_modelagainst hand-computed values;CrystKinetics.get_kineticssupersaturation branches.Phases.py/Streams.py— construct Liquid/Solid/Vapor streams, check derived properties and moment/distribution conversions.ThermoModule.py— property evaluations on a known compound DB.Commons.py— FVM helpers (high_resolution_fvm, limiter math),NameAnalysismapping.Connections.py—topological_bfsordering and recycle detection; unit conversion.Integration coverage (assimulo, mark
@pytest.mark.assimulo)Acceptance criteria
Upstream PR
Wave 2 — land upstream as several small, test-only PRs (one module or theme each), not a single large one. See #3.
Reverted PR provenance
This issue is part of the selective re-introduction of useful infrastructure from the reverted upstream work:
Implementation should stay small and reviewable, avoid repo-wide formatting, and preserve traceability through one focused PR per issue.