Skip to content

Enable playing ingame movie in non-campaign modes#2048

Merged
TaranDahl merged 9 commits intoPhobos-developers:developfrom
TaranDahl:MovieInMP
Apr 20, 2026
Merged

Enable playing ingame movie in non-campaign modes#2048
TaranDahl merged 9 commits intoPhobos-developers:developfrom
TaranDahl:MovieInMP

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

No description provided.

@TaranDahl TaranDahl added Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable Needs MP testing This PR needs to be tested for desync. labels Jan 18, 2026
@TaranDahl
Copy link
Copy Markdown
Contributor Author

TaranDahl commented Jan 18, 2026

Needs testing:

  • TAction PlayIngameMovie in skirmish
  • TAction PlayIngameMovieAndPause in skirmish
  • The two TAction in MP

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 18, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl
Copy link
Copy Markdown
Contributor Author

TaranDahl commented Feb 5, 2026

Bounty: 10 CNY for the 1st reviewer who gives valid review
image

Copy link
Copy Markdown
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks correct. You need to test in multiplayer though.

Also just to be sure (maybe some other place calls it) - patch 0x5BF2B9 and also see if there are any other similar checks by xrefs to movie statics

@Metadorius
Copy link
Copy Markdown
Member

I also give up the bounty.

@phoboscn-bot
Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/364/1

@TaranDahl TaranDahl added Tested and removed Needs testing Needs MP testing This PR needs to be tested for desync. labels Apr 20, 2026
@TaranDahl
Copy link
Copy Markdown
Contributor Author

@TaranDahl TaranDahl merged commit 2e4ea73 into Phobos-developers:develop Apr 20, 2026
4 checks passed
@TaranDahl
Copy link
Copy Markdown
Contributor Author

Also just to be sure (maybe some other place calls it) - patch 0x5BF2B9 and also see if there are any other similar checks by xrefs to movie statics

Oh, I forgot this. I'm looking into it right now.
My IDA says that the function at 0x5BF2B9 is never called.
I checked the movie array references; there are no similar checks, I think.

@Metadorius
Copy link
Copy Markdown
Member

My IDA says that the function at 0x5BF2B9 is never called.

Same, but some extension may use it. Just to be safe

@TaranDahl TaranDahl deleted the MovieInMP branch April 20, 2026 16:18
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bounty available ⚙️T1 T1 maintainer review is sufficient Tested ❓Unhardcoding / Customization Make something more tweakable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants