Let the edit-server dialog reveal the password - #125
Merged
Conversation
The password field has always been a PasswordBox, and that was the problem: PasswordBox's built-in "peek" button only appears once the box has taken focus *and* the user has typed a character. Editing an existing server assigns Password in code, so peek never showed up and the stored value could not be read back at all. Force PasswordRevealMode to Hidden and put an explicit reveal toggle in the field header, to the right of the label. The glyph swaps between RedEye and Hide; tooltip and automation name follow. No extra form row — the dialog already has 30-odd fields. Scoped to the password field only, per the issue. The other credential fields in this form (UUID, Reality keys, WireGuard keys) are plain TextBoxes and already show their values. Closes #124 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124.
add reveal/conceal button for password