fix(screensaver): add folder path config for screensaver folder mode - #1615
Open
alifakbxr wants to merge 1 commit into
Open
fix(screensaver): add folder path config for screensaver folder mode#1615alifakbxr wants to merge 1 commit into
alifakbxr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Resolves #1560
This pull request addresses the issue where the screensaver folder mode permanently falls back to the default
resources/frames/directory due to a missing UI input and a hardcoded path.Specifically, this PR:
folder_sourceparameter toScreensaverConfiguration.php(defaulting to'screensavers').inputfield forscreensaver_folder_sourcein the Admin Panel (lib/configsetup.inc.php).assets/js/screensaver.jsto dynamically read fromconfig.screensaver.folder_sourceinstead of using a hardcoded'screensavers'path when resolving images.resources/lang/en.json.Is there anything you'd like reviewers to focus on?
Please double check if there are any other specific translation files that need to be actively pushed prior to release for
screensaver:screensaver_folder_sourceandmanual:screensaver:screensaver_folder_source, or if they will be handled normally via Crowdin.AI used to create this Pull Request?
Yes, an AI Coding Assistant was used to identify the root cause of the fallback bug and scaffold the implementation. The AI analyzed the configuration tree and Admin UI components, then mapped and updated the missing variables so users can now explicitly define a folder path for their screensaver. The changes were strictly limited to the missing screensaver configuration input and the javascript path resolution logic.