Skip to content

Conversation

@GrahamSH-LLK
Copy link
Contributor

@GrahamSH-LLK GrahamSH-LLK commented Apr 15, 2025

Description

Upgrades to Vue 3 and necessary associated dependencies. Also fixes some issues with the layout and adds validation for object detection models.

Closes #885, closes #1943, closes #1449.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@GrahamSH-LLK GrahamSH-LLK requested a review from a team as a code owner April 15, 2025 01:50
@GrahamSH-LLK GrahamSH-LLK changed the title Nearly functional vue3 upgrade Vue 3 Upgrade Apr 15, 2025
samfreund

This comment was marked as resolved.

@GrahamSH-LLK

This comment was marked as resolved.

samfreund

This comment was marked as resolved.

@samfreund samfreund mentioned this pull request Apr 15, 2025
12 tasks
Gold856

This comment was marked as resolved.

@samfreund

This comment was marked as resolved.

@samfreund

This comment was marked as resolved.

@samfreund

This comment was marked as outdated.

@Gold856

This comment was marked as resolved.

@samfreund

This comment was marked as resolved.

@Gold856

This comment was marked as resolved.

@samfreund

This comment was marked as resolved.

@mcm001
Copy link
Contributor

mcm001 commented Apr 22, 2025

image
The style here changed a lot. Did we mean for this to happen?

image
This modal is a lot easier to miss now

image
Advanced Networking on my laptop looks funny lol why is the interface -1

Goofy aah new log viewer (old on right)
image

@samfreund
Copy link
Member

samfreund commented Apr 22, 2025

Advanced Networking on my laptop looks funny lol why is the interface -1

This could be from the big merge too.

Just tested, it's not

@samfreund

This comment was marked as resolved.

@samfreund samfreund dismissed stale reviews from Gold856 and themself May 5, 2025 23:31

outdated, and can't find it

@Gold856 Gold856 linked an issue May 6, 2025 that may be closed by this pull request
@GrahamSH-LLK GrahamSH-LLK requested a review from mcm001 May 6, 2025 15:04
@Gold856 Gold856 enabled auto-merge (squash) May 6, 2025 20:40
@Gold856 Gold856 disabled auto-merge May 6, 2025 20:49
@Gold856 Gold856 enabled auto-merge (squash) May 6, 2025 20:58
@Gold856 Gold856 merged commit bec8092 into PhotonVision:main May 6, 2025
39 checks passed
samfreund added a commit to samfreund/photonvision that referenced this pull request Jun 28, 2025
Upgrades to Vue 3 and necessary associated dependencies. Also fixes some
issues with the layout and adds validation for object detection models.

Closes PhotonVision#885, closes PhotonVision#1943, closes PhotonVision#1449.

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2024.3.1
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added

---------

Co-authored-by: Matt M <matthew.morley.ca@gmail.com>
Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: samfreund <techguy763@gmail.com>
@Gold856 Gold856 added the frontend Having to do with PhotonClient and its related items label Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flickering tag causing UI to shift Update PhotonClient to use Vue@3

4 participants