Skip to content

Rename NetworkingCard.vue to GlobalSettingsCard.vue #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gold856 merged 1 commit into from
Dec 5, 2025
Merged

Rename NetworkingCard.vue to GlobalSettingsCard.vue #2215

Gold856 merged 1 commit into from
Dec 5, 2025
+0 −0

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Dec 5, 2025 •
edited by Gold856
Loading

Description

In the UI, the title for this card is Global Settings. This more closely follows the UI.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • This PR has been linted.
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner December 5, 2025 08:43
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Dec 5, 2025
@samfreund samfreund requested a review from Gold856 December 5, 2025 09:09
@Gold856 Gold856 merged commit ca0923e into PhotonVision:main Dec 5, 2025
27 of 36 checks passed
@Gold856 Gold856 mentioned this pull request Dec 5, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gold856 Gold856 Gold856 approved these changes

Assignees

No one assigned

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samfreund @Gold856