Skip to content

Fix calibration typo#2471

Merged
mcm001 merged 1 commit into
PhotonVision:mainfrom
samfreund:fix-copy-pasta
May 24, 2026
Merged

Fix calibration typo#2471
mcm001 merged 1 commit into
PhotonVision:mainfrom
samfreund:fix-copy-pasta

Conversation

@samfreund
Copy link
Copy Markdown
Member

closes #2371

@samfreund samfreund requested a review from a team as a code owner May 6, 2026 01:31
@github-actions github-actions Bot added the backend Things relating to photon-core and photon-server label May 6, 2026
Copy link
Copy Markdown
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard is it to reproduce the bug in the OP? Would be good to have a dataset that used to produce invalid solutions

@samfreund
Copy link
Copy Markdown
Member Author

How hard is it to reproduce the bug in the OP? Would be good to have a dataset that used to produce invalid solutions

I haven't tried to reproduce the bug tbqh, I fear I don't have a board on me. Concur a dataset would be good.

@mcm001 mcm001 merged commit be27bb9 into PhotonVision:main May 24, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for Calibrate3dPipe using incorrect cy guess

2 participants