Skip to content

Conversation

@traversaro
Copy link
Contributor

The use of cmake -E echo to generate the deprecation message fails on Windows with a mysterious "CUSTOMBUILD : CMake error : %SRC_DIR%/build/include/controller_manager_parameters.hpp: no such file or directory" error. The problem is that < and > are special characters in Command Prompt. As an alternative solution, I generate the required string at configuration time via file(WRITE, and just use that file to compose the final generated header.

@traversaro traversaro marked this pull request as draft February 10, 2025 10:02
@traversaro
Copy link
Contributor Author

Converting to draft as I want first to test this solution in RoboStack/ros-jazzy#22 .

@traversaro traversaro marked this pull request as ready for review February 11, 2025 15:51
@traversaro
Copy link
Contributor Author

Converting to draft as I want first to test this solution in RoboStack/ros-jazzy#22 .

The compilation of downstream packages worked fine, I think we can consider the PR ready for review, thanks!

Copy link

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ubuntu noble, and has the same behavior as before.

@sea-bass sea-bass merged commit 7181bea into PickNikRobotics:main Feb 13, 2025
7 checks passed
@sea-bass
Copy link
Contributor

sea-bass commented Feb 13, 2025

@traversaro Thanks! Do you want a patch release to be set up after this fix?

@traversaro
Copy link
Contributor Author

@traversaro Thanks! Do you want a patch release to be set up after this fix?

I do not have a specific need for it. I added a patch locally on robostack, the important thing for me is to fix the problem upstream so in the long term we can remove the patch, but there is no hurry for doing a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants