Skip to content

feat(pipelines/pingcap/tidb/latest): enable coverage upload in check_dev2 job - #2172

Merged
ti-chi-bot[bot] merged 3 commits into
mainfrom
feature/add-coverage-for-tidb-integration-tests
Jun 21, 2023
Merged

feat(pipelines/pingcap/tidb/latest): enable coverage upload in check_dev2 job#2172
ti-chi-bot[bot] merged 3 commits into
mainfrom
feature/add-coverage-for-tidb-integration-tests

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

…_dev2` job

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2023

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

…`mysql-test` jobs

- mysql-test: using go native coverage data.
- check2: using bazel coverage (lcov format), and then convert it to cobertura format.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo
wuhuizuo force-pushed the feature/add-coverage-for-tidb-integration-tests branch from b6cd709 to 1a40e99 Compare June 19, 2023 09:16
@wuhuizuo
wuhuizuo force-pushed the main branch 4 times, most recently from 52328c4 to 512549d Compare June 19, 2023 12:03
@wuhuizuo
wuhuizuo marked this pull request as ready for review June 20, 2023 06:16
@wuhuizuo

wuhuizuo commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

…_dev2` job

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo
wuhuizuo force-pushed the feature/add-coverage-for-tidb-integration-tests branch from fda07af to 88aa780 Compare June 20, 2023 06:31

@purelind purelind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot

ti-chi-bot Bot commented Jun 20, 2023

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2023-06-20 08:59:10.496671117 +0000 UTC m=+93315.897921551: ☑️ agreed by purelind.

@wuhuizuo

Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jun 21, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 21, 2023
@ti-chi-bot
ti-chi-bot Bot merged commit 7700082 into main Jun 21, 2023
@ti-chi-bot
ti-chi-bot Bot deleted the feature/add-coverage-for-tidb-integration-tests branch June 21, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants