Skip to content

Adds hamburger menu to the Layers Pad with the remaining Layer actions#2056

Open
pedropaulosuzuki wants to merge 8 commits intoPintaProject:masterfrom
pedropaulosuzuki:master
Open

Adds hamburger menu to the Layers Pad with the remaining Layer actions#2056
pedropaulosuzuki wants to merge 8 commits intoPintaProject:masterfrom
pedropaulosuzuki:master

Conversation

@pedropaulosuzuki
Copy link
Contributor

With the new hamburger menu in the layers pad, we should have no discoverability problem (besides this addition, there's also the right-click menu on the layers). So, this also removes the Layers menu from the main Pinta hamburger menu.

image

Fixes #1386.

@pedropaulosuzuki
Copy link
Contributor Author

@cameronwhite any idea why this is breaking on MacOS? I cannot test because I don't have any of those devices.

Not needed anymore as the Layers menu is no longer between the submenus
@cameronwhite
Copy link
Member

@cameronwhite any idea why this is breaking on MacOS? I cannot test because I don't have any of those devices.

I don't think it's anything related to your PR - the same build failure just happened for the master branch after the PR I merged earlier. I'll try to look into it soon, but it's probably a bad update for one of the native libraries we install from homebrew

@cameronwhite
Copy link
Member

I think the CI issues might be fixed (or maybe are just randomly failing) - I got it to go green after re-running the jobs

A couple thoughts on the change:

  • The extra icon increases the minimum width of the sidebar, and this felt noticeably bigger to me
  • The icons for Move Layer Up / Down (which aren't the greatest icons to begin with) look pretty similar to the hamburger icon when they're all enabled
icons

What do you think about moving one or more buttons (perhaps the Move Layer Up / Down items) into the hamburger menu? Especially if #1218 is later implemented for drag and drop, these would be used less often

@pedropaulosuzuki
Copy link
Contributor Author

pedropaulosuzuki commented Mar 21, 2026

I think the CI issues might be fixed (or maybe are just randomly failing) - I got it to go green after re-running the jobs

A couple thoughts on the change:

* The extra icon increases the minimum width of the sidebar, and this felt noticeably bigger to me

* The icons for Move Layer Up / Down (which aren't the greatest icons to begin with) look pretty similar to the hamburger icon when they're all enabled
icons

What do you think about moving one or more buttons (perhaps the Move Layer Up / Down items) into the hamburger menu? Especially if #1218 is later implemented for drag and drop, these would be used less often

I think removing those icons before having drag and drop might make them hard to discover, and people would complain about needing to click twice when previously they only needed to click once™. But I agree they also look too similar at the moment. Maybe we could use up-symbolic and down-symbolic instead?

image image

@cameronwhite
Copy link
Member

Those icons look much better 👍

@pedropaulosuzuki
Copy link
Contributor Author

Those icons look much better 👍

Here are the new icons:

Screencast.from.22-03-2026.01.10.25.webm

Doesn't solve the increased width (which I'm not very happy either...), but should solve the other points you brought up.

@pedropaulosuzuki
Copy link
Contributor Author

pedropaulosuzuki commented Mar 22, 2026

@cameronwhite maybe we could put all the buttons inside a GtkBox, should reduce the space they occupy.

Here is how that would look:

image

Here is before this patch, the layers pad ends up with almost the exact same width:

image

And here is the patch as-is, meaning without the Gtk.Box reducing the width:

image

@pedropaulosuzuki
Copy link
Contributor Author

Another option would be to move the up and down buttons to the top of the bar, which would free some space below. We could do the same for the History pad and free some of that space in the bottom. This would require a more involved code change, though.

@cameronwhite
Copy link
Member

Thanks! It looks ok with the smaller spacing, my only gripe is that it's a bit inconsistent with other UI elements by avoiding the standard spacing for the Adwaita toolbar style

One other idea I had is related to #1386 (comment)
If the "Add New Layer" button became a button menu with the option to also "Import From File", moving the "Duplicate Current Layer" option in there could also be logical and remove an extra button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Remove "Layers" from hamburger menu

2 participants