docs(tools): align tool descriptions and prompts with behavior - #41
Open
asto18089 wants to merge 1 commit into
Open
docs(tools): align tool descriptions and prompts with behavior#41asto18089 wants to merge 1 commit into
asto18089 wants to merge 1 commit into
Conversation
Model-facing doc audit fixes across tui tools and prompts: stop advertising retired tool names (run_verifiers, exec_shell, fetch_url, web_search) in model-visible descriptions and extend the retired-name guard registry; fix web screenshot semantics (PDF-only, text output) and the search backend chain description; document shell background timeout limits, terminal buffer/timeout semantics, workflow pipeline signature and plan gates; declare required send_later message, github dirty-worktree refusal, gitignore asymmetry, and OCR format limits; add missing agent schema keys (allowed_tools), fix scout output contract and sentinel teaching, note translation rule precedence, skip the authority recap when a static composer owns the prompt, and add locale override setters for embedders. Signed-off-by: Pinvou Agent Review <review@pinvou.local>
|
Thanks @asto18089 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
对 Pinvou Agent 及 CodeWhale 的模型向文档(注入 LLM 上下文的工具 description / schema / prompt 文本)做了一次全量审计(30 个分区,约 16 万行),本 PR 修复其中属于引擎层的发现。所有修改仅触及注入模型的字符串与对应测试,不改行为逻辑。
主要修复(按审计四轴)
错误(描述指向不存在的工具名/与实现相反)
verify描述仍教模型调用已退役的run_verifiers;registry_sync/file_search/search引用exec_shell;fetch_url/web_search互相引用对方的退役名 → 全部改为现行面(Runaction /Bash/Webaction),并把 verify、registry MCP 三工具加入no_advertised_tool_teaches_a_retired_name守卫测试的 registry,堵住漏网web_search描述称 API 后端 "DuckDuckGo then Bing" 降级,实现与 forkguard 测试是 configured→Bing 单跳web.run screenshot未说明仅支持 PDF 且返回文本页;Web声称全部 action 网络策略感知但wait只限 loopback 且不走策略shell/task_shell_start的timeout_ms对background=true完全不生效,未告知模型workflowscript 的pipeline(thunks)签名错误(实为pipeline(items, ...stages),照抄会静默零分发);source_path限定 ".workflow.js 且必须在 workspace 内" 与实现(.ts/~/.codewhale/workflows)不符agent的type=custom引用 schema 中不存在的allowed_tools→ 补 schema 属性(解析器本就接受)遗漏
send_later缺message必填、githubclose 的脏工作区拒绝、gitignore在两个搜索工具间的不对称、image_ocr不支持的 PDF、terminal系列的 512KiB 缓冲丢弃/超时只放弃等待/Unix-only、Bash 30KB 流级截断、rememberworkspace 需带 origin 的 git 仓库、runtime_mcp运行时白名单、workflow verify失败把 run 终态翻为 Failed、create_goal建议"clear"但模型侧无清除工具等 → 均补入描述/schema重复/矛盾(提示层)
<codewhale:subagent.done>哨兵(应由运行时独占生成);scout 角色引言谈 CHANGES 节但 scout 契约已裁掉该节 → 删除两处AUTHORITY_RECAP仍无条件追加,指向不存在的 "### Whose word wins" 章节 → composer 存在时跳过 recap,附单测set_locale_preamble/closer_*_overridesetter(原覆盖单元格只有声明无 setter,宿主的 zh/ja 替换意图落空)验证
cargo check -p codewhale-tui通过;cargo fmt --all -- --check通过cargo test -p codewhale-tui --lib --locked forkguard_:57 passed / 0 failed说明
docs/fork-modifications.md/scripts/fork-guard.sh指纹登记image_query绕过网络策略;grep_files的truncated恒 false;Web/WebSearch/web.run 三份 search schema 手抄漂移;fetch_url→Web包装器描述借用重构