UI quick-wins: manual PLAN/WATCH toggle, tidy turn/date, in-flight hiring progress#686
Merged
Merged
Conversation
…dy turn/date, in-flight hiring progress VIEW-only (ADR-0006): no sim / RNG / turn-loop touched. 1. Manual PLAN<->WATCH toggle: a switch button in the mode banner (shows the target view) + a V keybind, so the player can flip screens at will to look things over. Reuses the existing scaffold's set_mode; the game's own COMMIT / month-review transitions still drive the mode as before. 2. Tidy turn/time: one element "Turn 14 - Fri 21 Jul 2017" (turn = the plan period, counted; calendar date = the human when). Folds the old month-badge + separate "Turn N" duplicate into TurnLabel and hides the redundant TurnCountLabel. 3. In-flight hiring tracker: a lightweight list under the committed-month queue in the shared instrument column, showing each cooking interview/offer/networking job and each onboarding checklist with a progress bar + "done/total" (visible in both PLAN and WATCH since jobs cook during day-tick playback). Fast gate: 437 tests, 0 failures, 45/45 files. test_screen_mode 6/6. Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
PipFoweraker
added a commit
that referenced
this pull request
Jul 17, 2026
feat(ship): P0 batch -- quit-to-menu, honest defeat title, event-feed filter (+#686)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three contained VIEW-layer quick-wins (Pip request). No simulation / seeded RNG / turn logic / replay touched (ADR-0006) -- all changes read the state payload and only add/format UI.
1. Manual PLAN <-> WATCH view toggle
The two-view scaffold existed but couldn't be switched manually. Added a switch button in the mode banner (label shows the target view:
WATCH >/< PLAN) plus aVkeybind inmain_ui._input. Both call the newScreenModeController.toggle_mode(), which just flips which screen subtree is visible. The game's own COMMIT-the-month / month-review transitions still drive the mode exactly as before; this only lets the player peek in between.2. Tidy turn / time display
Replaced the muddled split ("July 2017 . Jul 21" badge + a separate "Turn N") with ONE element:
Turn = the plan/decision period (counted); the calendar date is the human "when". New helper
_format_turn_datetime(state)formats offstate.turn+state.calendar; the now-redundantTurnCountLabelis hidden. ASCII only.3. In-flight hiring steps with progress
New lightweight Gantt-ish list mounted under the committed-month queue in the shared instrument column (so it's visible in both PLAN and WATCH, since jobs cook during day-tick playback). For each in-flight
hiring.jobsentry it shows kind + candidate + a progress bar +done/total ticks:Interview: <name> [==== ] 2/3 ticksOffer: <name> [==] 1/2 ticksNetworking: sourcing a lead 1/2 ticksOnboarding hires (checklist, not tick-timed) also surface:
Onboarding: <name> 1/2 steps(laptop [+ visa]). Durations read fromBalance(view read only).Keybinds
V-- toggle PLAN <-> WATCH view.Verify
run_godot_tests.py --quick --ci-mode --min-tests 300: 437 tests, 0 failures, 45/45 files.godot --headless --import: clean,main_ui.gd+screen_mode.gdload with no parse error.test_screen_mode.gd: 6/6 pass.Files:
godot/scripts/ui/main_ui.gd,godot/scripts/ui/screen_mode.gd.Do NOT merge / do NOT push to base -- for Pip's review.
🤖 Generated with Claude Code